<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2496#discussion_r364231127">test/controllers/users_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -344,27 +344,13 @@ def test_save_referer_params
   end
 
   def test_logout_without_referer
-    get :logout
-    assert_response :success
-    assert_template :logout
-    assert_select "input[name=referer][value=?]", ""
-
-    session_id = assert_select("input[name=session]").first["value"]
-
-    get :logout, :params => { :session => session_id }
</pre>
<p>I'm inclined to leave in the get test in method which checks that GET returns the login page - obviously get rid of the assertion that the session ID is in the returned form.</p>
<p>I know you're doing it in the system tests as well, but the cases here do check extra things like that the fallback page preserves the referer?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2496?email_source=notifications&email_token=AAK2OLK4S2K5AXM4IBY6Q7DQ4XIUPA5CNFSM4KEIBWS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRA6PWI#pullrequestreview-339863513">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPOXCMRGMMKFLW5JJTQ4XIUPANCNFSM4KEIBWSQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLKCJ3APEHQDURTLGSTQ4XIUPA5CNFSM4KEIBWS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRA6PWI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2496?email_source=notifications\u0026email_token=AAK2OLK4S2K5AXM4IBY6Q7DQ4XIUPA5CNFSM4KEIBWS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRA6PWI#pullrequestreview-339863513",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2496?email_source=notifications\u0026email_token=AAK2OLK4S2K5AXM4IBY6Q7DQ4XIUPA5CNFSM4KEIBWS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRA6PWI#pullrequestreview-339863513",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>