<p><b>@mmd-osm</b> commented on this pull request.</p>
<blockquote>
<p>I think the set_default_request_format would be better applied to every api method, but you only have it for a few (e.g. before_action :set_default_request_format, :except => [:create, :update, :delete]). Can you talk more about that?</p>
</blockquote>
<p>Yes, that's also intentional. On the one hand, I only wanted to include those methods for which we have some test coverage. On the other hand, some of those methods return plain text, rather than XML. I felt like overriding request.format could potentially introduce some havor in the future, so I deliberately excluded those methods which are not in scope right now.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2485?email_source=notifications&email_token=AAK2OLP3ISWT6WWBIL4AGXTQ7BPLZA5CNFSM4KAKS5KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSU3J4Q#pullrequestreview-346666226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMJUBVXQSBFG4XRPGDQ7BPLZANCNFSM4KAKS5KA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLIFXYIBETX2H4QOJ33Q7BPLZA5CNFSM4KAKS5KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSU3J4Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2485?email_source=notifications\u0026email_token=AAK2OLP3ISWT6WWBIL4AGXTQ7BPLZA5CNFSM4KAKS5KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSU3J4Q#pullrequestreview-346666226",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2485?email_source=notifications\u0026email_token=AAK2OLP3ISWT6WWBIL4AGXTQ7BPLZA5CNFSM4KAKS5KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSU3J4Q#pullrequestreview-346666226",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>