<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> I'm following up on the change to replace geckodriver in .travis.yml with using the titusfortner/webdrivers gem.  Somehow it works locally (yes, I've taken geckodriver out my $PATH).  But tests fail on travis because webmock is preventing the download of the webdrivers.</p>
<p>I looked back in the git history to see where webmock was introduced and why.  Seems to be used in test_helper.rb in with_http_stubs().  So instead of calling out to geonames, geocoder_ca, and nominatim, we just return data from disk.</p>
<p>The policy to disable network connection (except for localhost) is also in test_helper.rb line 24.</p>
<p>Looks like webmock allows a whitelist of allowed sites.  <a href="https://www.rubydoc.info/gems/webmock/2.0.2#External_requests_can_be_disabled_while_allowing_specific_requests" rel="nofollow">https://www.rubydoc.info/gems/webmock/2.0.2#External_requests_can_be_disabled_while_allowing_specific_requests</a>  I would add for example <a href="https://chromedriver.storage.googleapis.com" rel="nofollow">https://chromedriver.storage.googleapis.com</a></p>
<p>Do you suggest doing that?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2390?email_source=notifications&email_token=AAK2OLIP3SXXKHYTDYJWDP3RBAOGTA5CNFSM4JAHYW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKT4ZLA#issuecomment-581422252">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP4N4WIHGOP53SNYILRBAOGTANCNFSM4JAHYW4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLIQMNGAVVJJCC4PVDDRBAOGTA5CNFSM4JAHYW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKT4ZLA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2390?email_source=notifications\u0026email_token=AAK2OLIP3SXXKHYTDYJWDP3RBAOGTA5CNFSM4JAHYW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKT4ZLA#issuecomment-581422252",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2390?email_source=notifications\u0026email_token=AAK2OLIP3SXXKHYTDYJWDP3RBAOGTA5CNFSM4JAHYW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKT4ZLA#issuecomment-581422252",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>