<p><b>@bezdna</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2537#discussion_r385011790">app/views/layouts/map.html.erb</a>:</p>
<pre style='color:#555'>> @@ -40,8 +40,12 @@
 
     <% unless current_user %>
       <div class="welcome">
-        <h2><%= t "layouts.intro_header" %></h2>
-        <div class="close-wrap"><span class="icon close"></span></div>
+        <div class="welcome-header">
+          <h2><%= t "layouts.intro_header" %></h2>
+          <button type="button" class="button close" aria-label="Close">
+            <span class="icon close"></span>
+          </button>
+        </div>
</pre>
<ol>
<li>In terms of semantics, a button is not a title element</li>
<li>in terms of accessibility, if the button is in a block with a heading, this implies that the button will close the heading, not the block.</li>
<li>from the layout point of view, managing floats in RTL and LTR is more difficult, and this should be monitored.</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2537?email_source=notifications&email_token=AAK2OLO2N34ZUF42QF4JA6TRE6DEXA5CNFSM4KVHOPV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXE2DZQ#discussion_r385011790">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI33XJC4A3VTML7QDLRE6DEXANCNFSM4KVHOPVQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLKYPL4W2UP25MY6NY3RE6DEXA5CNFSM4KVHOPV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXE2DZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2537?email_source=notifications\u0026email_token=AAK2OLO2N34ZUF42QF4JA6TRE6DEXA5CNFSM4KVHOPV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXE2DZQ#discussion_r385011790",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2537?email_source=notifications\u0026email_token=AAK2OLO2N34ZUF42QF4JA6TRE6DEXA5CNFSM4KVHOPV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXE2DZQ#discussion_r385011790",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>