<p></p>
<blockquote>
<p>Converting <code>controller</code> tests to <code>system</code> tests would be welcome, but it's a giant project!</p>
</blockquote>
<p>Further investigation shows that there's a middle ground option - updating our controller tests to inherit from <code>ActionDispatch::IntegrationTest</code> instead of <code>ActionController::TestCase</code> will also work. This is anyway recommended by the rails guide for controller tests (not just integration tests) and also <a href="https://api.rubyonrails.org/v6.0.2.2/classes/ActionController/TestCase.html" rel="nofollow">the documentation for <code>ActionController::TestCase</code></a>.</p>
<p>It would involve a bunch of refactoring of the tests, but is much less work than rewriting them into system tests, even though system tests are the long term goal.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2563#issuecomment-611086270">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIQKUOPJREL7723BATRLSXHLANCNFSM4LOVDDGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLPDUQNVJPARD5QQPKLRLSXHLA5CNFSM4LOVDDG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOERWG7PQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2563#issuecomment-611086270",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2563#issuecomment-611086270",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>