<p></p>
<blockquote>
<p>Aside from the fact that it won't work? It's trying to pluralise but that only works if the variable is called <code>count</code> and neither variable here is called that.</p>
</blockquote>
<p>The <code>:count</code> is being passed, and the pluralisation will be triggered, even though <code>%{count}</code> doesn't appear in the string itself.</p>
<p>I think this is a neat workaround to avoid changing the parameter names in the existing strings.</p>
<blockquote>
<p>The core problem that is that there are two numeric variables here and either one could be singular or plural but pluralisation only supports a single controlling variable.</p>
</blockquote>
<p>Yes, this is a limitation. I've done some research and found very little on the topic (<a href="https://stackoverflow.com/questions/24303896/i18n-pluralization-of-a-sentence-with-few-counts" rel="nofollow">1</a> <a href="https://stackoverflow.com/questions/45199525/rails-5-can-you-pluralize-two-words-in-a-string-with-two-different-counts" rel="nofollow">2</a>). But I think that in many cases, there only needs to be one noun to pluralise, and so I think we're better off merging this as-is, rather than waiting for perfection.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2431#issuecomment-614142346">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJI3L2IKH5TXRFB3ALRMXOCFANCNFSM4JMHNWCQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLPXTLBIIOFW7E7CJL3RMXOCFA5CNFSM4JMHNWC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOESNRDCQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2431#issuecomment-614142346",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2431#issuecomment-614142346",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>