<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2667#discussion_r445039433">package.json</a>:</p>
<pre style='color:#555'>> @@ -1,7 +1,9 @@
 {
   "name": "openstreetmap",
   "private": true,
-  "dependencies": {},
+  "dependencies": {
+    "bs-custom-file-input": "^1.3.4"
+  },
</pre>
<p>We haven't been using yarn to manage javascript for the actual web site to date, although I have experimented with it. I was slightly surprised it worked but I see <code>node_modules</code> has crept on to the include path at some point, and the other infrastructure change I made for it has also been made for other reasons.</p>
<p>I guess there's no reason not to do it, other than trying to keep everything in one place - although is other stuff we could manage via yarn there are some things where we can't at the moment so would have to stick with vendorer.</p>
<p>It does mean that we will need to run yarn as part of the deployment though and to date we don't have any tooling for that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2667#pullrequestreview-436837197">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPLHI7VW775J7VVNIDRYIWINANCNFSM4OG2MFVA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLJET7I3LCQSYE6LRDLRYIWINA5CNFSM4OG2MFVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODIEZWTI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2667#pullrequestreview-436837197",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2667#pullrequestreview-436837197",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>