<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2725#discussion_r458893967">test/controllers/changesets_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -131,7 +145,7 @@ def test_index_user_not_found
   def test_index_friends
     private_user = create(:user, :data_public => true)
     friendship = create(:friendship, :befriender => private_user)
-    create(:changeset, :user => friendship.befriendee)
+    changeset = create(:changeset, :user => friendship.befriendee, :num_changes => 1)
</pre>
<p>Shouldn't this create some "other" changesets to make sure we only get the expected one?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2725#discussion_r458894069">test/controllers/changesets_controller_test.rb</a>:</p>
<pre style='color:#555'>>    end
 
   ##
   # Checks the display of the nearby user changesets listing
   def test_index_nearby
     private_user = create(:user, :data_public => false, :home_lat => 51.1, :home_lon => 1.0)
     user = create(:user, :home_lat => 51.0, :home_lon => 1.0)
-    create(:changeset, :user => user)
+    changeset = create(:changeset, :user => user, :num_changes => 1)
</pre>
<p>Same here?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2725#pullrequestreview-453449892">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJXKHGYPMAZVSLG4D3R44C5VANCNFSM4PE22OLA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLILUEBD4WP62IX35ILR44C5VA5CNFSM4PE22OLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODMDRRJA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2725#pullrequestreview-453449892",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2725#pullrequestreview-453449892",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>