<p></p>
<p>I've reviewed this PR again today, and for a few reasons, I don't think it's yet suitable for merging:</p>
<ul>
<li>There's no tests included.</li>
<li>There should be consistency between what's available through the website and through the API.</li>
<li>The permissions checks should be done via the abilities system, rather than hardcoded roles.</li>
<li>Redaction vs simple hiding of data needs to be decided, and work through the implications for dumps.</li>
</ul>
<p>The first two should be fairly straightforward to fix, so I'd be happy to see a fresh PR with the above items addressed. For the fourth one, it might be worth discussing in an issue before coding.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1167#issuecomment-701413445">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJA6ZCKBHDCR5ZK6QTSIM3M5ANCNFSM4B4TKLAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLJ2HUBH3YU2PY2UHPLSIM3M5A5CNFSM4B4TKLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFHHLQRI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1167#issuecomment-701413445",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1167#issuecomment-701413445",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>