<p>This PR includes a small refactoring, and marking many utility methods in the test suite as <code>private</code>, in order that we can enable the <code>Minitest/TestMethodName</code> cop.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/2918'>https://github.com/openstreetmap/openstreetmap-website/pull/2918</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactor test to use general basic_authorization_header method</li>
<li>Ensure that test utility methods are marked as private</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-29beaabe278fd17493296745cecb67919f0906b47b8246ab770f5517615d9ef7">.rubocop_todo.yml</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-86f561066896ab4c4f2fd512c55cc748080ab2e25de3690f85799488afab194f">test/abilities/api_capability_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-8a9c95ea5b86d8f52f78210e2ff053062ca9a234754dff890fb8aae45343ff4c">test/controllers/api/nodes_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-7ee3168144cba950374d481967d27d39db360d6dfb366aa9033b42f32cb98256">test/controllers/api/old_nodes_controller_test.rb</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-da8c6d0ce9e50a5d0d4517cb17a60cc0df2f286b573ea8132fd903ad8c227237">test/controllers/api/relations_controller_test.rb</a>
(42)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-ffae22d15753b266411f4613c7a78242cfd5a5ab95aad3484ce9728179a76334">test/controllers/api/ways_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-b68a09a5dc0e0cffcd99b27761111b06a86bb45001912b9fabf3618a3dc464d1">test/helpers/browse_helper_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-b06fdb1b027508cfa9d420409eeb1db54c3e81d51e16c5a6b55a53cb05efe047">test/integration/client_applications_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-2a123e708a52790d390ecf444964d805e33240fe802b78a3ace725074cb0212e">test/integration/short_links_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-a1eb8d1c90c9c5b030a23251f16373194677dff9ba313f63dd850d586ea15c85">test/integration/user_blocks_test.rb</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918/files#diff-19aa16b7c7e0598a9b16e64733cafc53ac88bc34c658524342c0a0bffde8affc">test/integration/user_creation_test.rb</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2918.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/2918.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2918.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/2918.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2918">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPTQTBNXJFUV3OID5DSM72XVANCNFSM4TCFECUA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLJ63T3HDBMCPM47J6LSM72XVA5CNFSM4TCFECUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4K4XKIDQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2918",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2918",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>