<p>This PR fixes some cases where we are using optional boolean parameters, to use keyword arguments instead.</p>
<p>I think this is particularly useful where the method definition lies elsewhere, since it's not obvious what an isolated 'true' or 'false' means.</p>
<p><a rel="nofollow" href="https://docs.rubocop.org/rubocop/1.0/cops_style.html#styleoptionalbooleanparameter">https://docs.rubocop.org/rubocop/1.0/cops_style.html#styleoptionalbooleanparameter</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/2955'>https://github.com/openstreetmap/openstreetmap-website/pull/2955</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Prefer keyword arguments when method has optional boolean arguments</li>
  <li>Prefer keyword arguments when method has optional boolean arguments</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-29beaabe278fd17493296745cecb67919f0906b47b8246ab770f5517615d9ef7">.rubocop_todo.yml</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-6e9fe051c0ef757618e376ffe731dfca8d4960ef0838b7d6a05609b46ba0fad1">app/controllers/api/notes_controller.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-a3926db6e853b8fb775271c951ca4789b9ba3884dfedc631bf211bd650952882">app/controllers/browse_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-805f375f16be972c83e5a4b604bd1ff1710afafa7319c76b32daeb11be9feb7c">app/controllers/changeset_comments_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-cf3fe9dc357f802fd9155582ffc8c6f71185065267991a2135323ad2d044b4f3">app/controllers/changesets_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-32118282fc2a82b607c0052b4a7bf90a81869cfae973c63e9552534800c14525">app/helpers/browse_helper.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-fba7159a4abd78f8b24f765a0c58ebe47a24be99e185c373175f20f612a5d781">app/views/browse/changeset.html.erb</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-b68a09a5dc0e0cffcd99b27761111b06a86bb45001912b9fabf3618a3dc464d1">test/helpers/browse_helper_test.rb</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-075b225564d8d03a13f5ae8eae9a31fa4e0f655622b405a28f715ed467cbeebe">test/models/diary_entry_test.rb</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-9fd2e1fe5658049094afe3aa0ab829848cd04fd0b3f62d56ad51b1ae40efdc2e">test/models/trace_test.rb</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955/files#diff-9ea33b6ae2df977603b566d0f7cffaa38faf8ecb38dfe393c85d662b606281b4">test/models/tracetag_test.rb</a>
    (20)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2955.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/2955.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2955.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/2955.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2955">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIGDPBGF2OLS673XM3SPK4GNANCNFSM4TSGNZXQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLJVWRQNXW7KVWEAYDTSPK4GNA5CNFSM4TSGNZX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LBJJIDA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2955",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2955",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>