<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2921#discussion_r522875819">app/helpers/title_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -6,7 +6,7 @@ def self.coder
   def set_title(title = nil)
     if title
       @title = TitleHelper.coder.decode(title.gsub("<bdi>", "\u202a").gsub("</bdi>", "\u202c"))
-      response.headers["X-Page-Title"] = ERB::Util.u(@title + " | " + t("layouts.project_name.title"))
+      response.headers["X-Page-Title"] = ERB::Util.u("#{@title} | #{t('layouts.project_name.title')}")
</pre>
<p>I'd be happy with the format. I suspect you're just not used to seeing the named argument style but we do have other places using it. That said I've merged this and added <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/45d4242f9d29b00e69aeb016e99a0ce230eb71d9/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/45d4242f9d29b00e69aeb016e99a0ce230eb71d9"><tt>45d4242</tt></a> on top using the variable based approach.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2921#discussion_r522875819">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ2PZY2F3V2T6TWX2LSPUGBTANCNFSM4TCRTX2Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLLXF2UQDSBJMOWFKLDSPUGBTA5CNFSM4TCRTX22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD6LJ5XA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2921#discussion_r522875819",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2921#discussion_r522875819",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>