<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2970#discussion_r526721954">app/views/user_mailer/_gpx_description.html.erb</a>:</p>
<pre style='color:#555'>> @@ -1,12 +1,8 @@
-<%= t "user_mailer.gpx_notification.your_gpx_file" %>
-<strong><%= @trace_name %></strong>
-<%= t "user_mailer.gpx_notification.with_description" %>
-<em><%= @trace_description %></em>
-<% if @trace_tags.length>0 %>
-  <%= t "user_mailer.gpx_notification.and_the_tags" %>
-  <em><% @trace_tags.each do |tag| %>
-    <%= tag.tag.rstrip %>
-  <% end %></em>
+<% trace_name = tag.strong(@trace_name) %>
+<% trace_description = tag.em(@trace_description) %>
+<% if @trace_tags.length > 0 %>
+  <% tags = @trace_tags.map { tag.tag.rstrip.join(" ") } %>
</pre>
<blockquote>
<p>and I'll look into the <code>safe_join</code> aspect too</p>
</blockquote>
<p>Actually, I don't think we want the safe_join here, since <code>tag.tag</code> isn't made up of existing safe strings (e.g. already-built html) - <code>tag.tag</code> is just a regular string. So <code>join</code> is the best approach and the whole string will be properly escaped when interpolated into the erb.</p>
<p>Of course, <code>join</code> is still in the wrong place!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2970#discussion_r526721954">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIOOHMCGVNCVXNMSILSQTSAPANCNFSM4T2KJZSA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLJLBM34S663EHI5JATSQTSAPA5CNFSM4T2KJZSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD7L5TSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2970#discussion_r526721954",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2970#discussion_r526721954",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>