<p></p>
<p><b>@tordans</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r549446418">.github/workflows/docker.yml</a>:</p>
<pre style='color:#555'>> + uses: actions/checkout@v1
+ - name: Poke config
+ run: |
+ cp config/example.storage.yml config/storage.yml
+ cp config/docker.database.yml config/database.yml
+ touch config/settings.local.yml
+ - name: Build Docker Image
+ run: |
+ docker-compose build
+ - name: Start Docker-Compose
+ run: |
+ docker-compose up -d
+ sleep 15 # let the DB warm up a little
+ - name: Prepare Database
+ run: |
+ docker-compose run --rm web rake db:migrate
</pre>
⬇️ Suggested change
<pre style="color: #555">- docker-compose run --rm web rake db:migrate
+ docker-compose run --rm web rails db:migrate
</pre>
<p>Since we are on a fairly new version of Rails, this is the same and looks a bit nicer and is more up to date.</p>
<p>(I will comment only this one random instance, but there are a few of them)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559256980">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLEWNOTUCPI47A7TVTSXDFOHANCNFSM4JDURRXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLK7BKJM2L3XR3ZWMY3SXDFOHA5CNFSM4JDURRXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEFKZLFA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559256980",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559256980",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>