<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r549857643">docker/postgres/Dockerfile</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,7 @@
+FROM postgres:11
+
+# Add db init script to install OSM-specific Postgres functions/extensions.
+ADD docker/postgres/openstreetmap-postgres-init.sh /docker-entrypoint-initdb.d/
+
+# Custom database functions are in a SQL file.
+ADD db/functions/functions.sql /usr/local/sbin/osm-db-functions.sql
</pre>
<p>A couple of comments:</p>
<ul>
<li>
<p>/usr/local/sbin seems to be a somewhat unusual location for sql scripts.</p>
</li>
<li>
<p>Also, I'm not 100% sure if we need this script at all. At least maptile_for_point (for the /changes endpoint) and xid_to_int4 (for the old osmosis based replication) are likely candidates to be removed in the near future. tile_for_point functionality is probably part of the quad_tile, and might also no longer be needed.</p>
</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559710563">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP5MMNWADPD5RZVXJLSXJDNZANCNFSM4JDURRXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLPWJHXHKQ5ZX4SUWNTSXJDNZA5CNFSM4JDURRXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEFOICYY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559710563",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559710563",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>