<ul>
<li>introduce bootstrap tabs to switch the views</li>
<li>introduce <code>content_for :heading_class</code> to remove the padding below the bootstrap tabs</li>
<li>update the rss-image to use a svg, adopted from <a href="https://icons.getbootstrap.com/icons/rss/" rel="nofollow">https://icons.getbootstrap.com/icons/rss/</a> (without the outer border)</li>
<li>move rss- and new-button away from the view-switching actions</li>
<li>the <code>@tag</code> logic was broken. introduce new link to remove the tag-filter; the tabs keep the filter once given</li>
<li>use <code>&.</code> syntax nil-safety so we can remove <code>@display_name</code></li>
</ul>
<p>I will wait for a first review of this.<br>
Still to do is …</p>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Check specs</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Add translations for the two new strings (hint about how to this is welcome)</li>
</ul>
<p>The remove-tag-feature is not ideal IMO, but on the other hand it was broken ATM and nobody noticed so it was probably not that important and IMO not worth adding even more complexity.</p>
<h2>Screenshots</h2>
<p><strong>gps – logged-in – someone-else</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467062-4cb8d680-4d4b-11eb-8e67-bd607fa40cf3.png"><img width="1054" alt="gps--logged-in--someone-else" src="https://user-images.githubusercontent.com/111561/103467062-4cb8d680-4d4b-11eb-8e67-bd607fa40cf3.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-in – all</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467063-4d516d00-4d4b-11eb-91f5-432cf3155727.png"><img width="1034" alt="gps--logged-in--all" src="https://user-images.githubusercontent.com/111561/103467063-4d516d00-4d4b-11eb-91f5-432cf3155727.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-in – my</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467064-4dea0380-4d4b-11eb-9610-520bec86bdf9.png"><img width="1038" alt="gps--logged-in--my" src="https://user-images.githubusercontent.com/111561/103467064-4dea0380-4d4b-11eb-9610-520bec86bdf9.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-out – someone-else</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467054-488cb900-4d4b-11eb-8ca7-afd9ef0807b8.png"><img width="1043" alt="gps--logged-out--someone-else" src="https://user-images.githubusercontent.com/111561/103467054-488cb900-4d4b-11eb-8ca7-afd9ef0807b8.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-out – all</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467055-4a567c80-4d4b-11eb-8144-95d4947cec36.png"><img width="1058" alt="gps--logged-out--all" src="https://user-images.githubusercontent.com/111561/103467055-4a567c80-4d4b-11eb-8144-95d4947cec36.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-in – someone-else – tag filter active</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467058-4b87a980-4d4b-11eb-8fe6-95940dacfd49.png"><img width="1044" alt="gps--logged-in--someone-else--tag" src="https://user-images.githubusercontent.com/111561/103467058-4b87a980-4d4b-11eb-8fe6-95940dacfd49.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-in – all – tag filter active</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467059-4c204000-4d4b-11eb-946d-b97d3a0ab657.png"><img width="1045" alt="gps--logged-in--all--tag" src="https://user-images.githubusercontent.com/111561/103467059-4c204000-4d4b-11eb-946d-b97d3a0ab657.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-in – my – tag filter active</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467060-4cb8d680-4d4b-11eb-9381-71404f215a84.png"><img width="1039" alt="gps--logged-in--my--tag" src="https://user-images.githubusercontent.com/111561/103467060-4cb8d680-4d4b-11eb-9381-71404f215a84.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-out – someone-else – tag filter active</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467057-4aef1300-4d4b-11eb-8183-cf699a6716c4.png"><img width="1065" alt="gps--logged-out--someone-else--tag" src="https://user-images.githubusercontent.com/111561/103467057-4aef1300-4d4b-11eb-8183-cf699a6716c4.png" style="max-width:100%;"></a></p>
<p><strong>gps – logged-out – all – tag filter active</strong><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/111561/103467056-4a567c80-4d4b-11eb-84ed-038a4b7ba93c.png"><img width="1045" alt="gps--logged-out--all--tag" src="https://user-images.githubusercontent.com/111561/103467056-4a567c80-4d4b-11eb-84ed-038a4b7ba93c.png" style="max-width:100%;"></a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3034'>https://github.com/openstreetmap/openstreetmap-website/pull/3034</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Traces#index: Introduce tab navigation, fix tag-filter</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3034/files#diff-2602c06a2618f83c1470c924563b55c738e3c94ffb6480e637ca0f4ce130eaba">app/controllers/traces_controller.rb</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3034/files#diff-8b8c462d0fcdd66c2a5a7e750cf4512c0b9f71dda5c04fc3cf4c5183454b9f38">app/views/layouts/_content.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3034/files#diff-446cb1205994b7918b2a68c30feb162b10fce3a0a9e05c716d9e966df4ba0507">app/views/traces/index.html.erb</a>
(66)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3034.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3034.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3034.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3034.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3034">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJHLZ43WBLIMP53NGTSX6HL5ANCNFSM4VRLD5XA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLPE5NNHYN5JODBJV5LSX6HL5A5CNFSM4VRLD5XKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LSYFEMA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3034",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3034",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>