<p></p>
<p>I'm keen to see this finished and merged, but I've run out of time this week for a second review.</p>
<p>What I should mention is that when I tried it previously it slightly messed up my regular development environment. This is, as far as I can figure out, because when I ran the docker container it wrote some cache files to the <code>project_repo/tmp</code> directory <em>as root</em> (<g-emoji class="g-emoji" alias="nauseated_face" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f922.png">🤢</g-emoji>). When I then tried to run rails outside of the container, everything failed since my regular user couldn't update those files. I had to do some <code>find . -group root | sudo xargs rm</code> outside of the container to get rid of them.</p>
<p>I'm not sure if it's possible to avoid this, i.e. configure it so that whenever a process within the container writes to the non-containerised filesystem, for it to do so as my user instead of root. But I thought I would mention it in case any Docker experts know how to do this.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2409#issuecomment-755513698">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIUTBDMHAQLQ26VLE3SYSWUVANCNFSM4JDURRXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLPHNOKVPR2P2W4CXVTSYSWUVA5CNFSM4JDURRXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFUEDSYQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#issuecomment-755513698",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2409#issuecomment-755513698",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>