<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p>Presumably at some point thing like the omniauth callbacks that use those shared routines should themselves move to the session controller given they are concerned with creating sessions? Though with the complication that they're also used in account creation :-(</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3147#discussion_r600493211">test/controllers/sessions_controller_test.rb</a>:</p>
<pre style='color:#555'>> +    )
+    assert_recognizes(
+      { :controller => "sessions", :action => "destroy", :format => "html" },
+      { :path => "/logout.html", :method => :get }
+    )
+  end
+
+  def test_login
+    user = create(:user)
+
+    get login_path
+    assert_response :redirect
+    assert_redirected_to login_path(:cookie_test => true)
+    follow_redirect!
+    assert_response :success
+    assert_template "sessions/new"
</pre>
<p>Presumably these template assertions could drop the <code>sessions</code> prefix now they been moved?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3147#pullrequestreview-619739377">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNSOKJ43DAJU2UYIRDTFHU3JANCNFSM4ZXIWR5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLMCJQPWMMIQKP3MNALTFHU3JA5CNFSM4ZXIWR5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOETYHR4I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3147#pullrequestreview-619739377",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3147#pullrequestreview-619739377",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>