<p></p>
<blockquote>
<p>Presumably at some point thing like the omniauth callbacks that use those shared routines should themselves move to the session controller given they are concerned with creating sessions?</p>
</blockquote>
<p>I took that approach during development, but I didn't like it, since the Devise::SessionsController doesn't have any omniauth things in it. However, there is an <a href="https://github.com/heartcombo/devise/blob/master/app/controllers/devise/omniauth_callbacks_controller.rb">omniauth callbacks controller</a> for devise - I haven't checked yet, but they might go in there, but I really don't know much about omniauth yet so I'm not sure if they are doing the same thing.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3147#issuecomment-805845649">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLVRYIVWTZQQBOH4ZLTFHV6NANCNFSM4ZXIWR5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLOKUKVFIQCVVPIM72DTFHV6NA5CNFSM4ZXIWR5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGAEDVEI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3147#issuecomment-805845649",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3147#issuecomment-805845649",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>