<p></p>
<p><b>@harry-wood</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3169#discussion_r610818565">test/controllers/notes_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -73,4 +73,11 @@ def test_index_paged
     assert_response :success
     assert_select "table.note_list tr", :count => 11
   end
+
+  def test_empty_page
</pre>
<p>I created a test method for this scenario. Would your normally split it out like that or bundle this into one of the existing test methods? I'm more accustomed to creating lots of separate <code>it</code> blocks in nested <code>context</code> blocks in rspec</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3169#pullrequestreview-632672562">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNGWOGD4WWSBLNRC4TTH47EPANCNFSM42VNV4XA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLIEB4HAVRZWIPCI75TTH47EPA5CNFSM42VNV4XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEW25CMQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3169#pullrequestreview-632672562",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3169#pullrequestreview-632672562",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>