<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3169#discussion_r622002140">test/controllers/notes_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -73,4 +73,11 @@ def test_index_paged
     assert_response :success
     assert_select "table.note_list tr", :count => 11
   end
+
+  def test_empty_page
</pre>
<p>I'm happy with smaller tests.</p>
<p>I also agree with you with the rspec topic - I use it on all my other projects, and I much prefer having the context blocks with individual tests, rather than ending up with our normal mega-test that are dozens of assertions and 'paragraphs' long. But I'm not sure if there's much appetite for rewriting the test suite yet, until we have a few more developers at least!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3169#discussion_r622002140">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOKWPHWUC4MXIK5JNLTK7JI3ANCNFSM42VNV4XA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLP4QZNPWPNMAJS7HVDTK7JI3A5CNFSM42VNV4XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE2HAJWY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3169#discussion_r622002140",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3169#discussion_r622002140",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>