<p>This forms the first part of implementing <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="852597215" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3167" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/3167/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/3167">#3167</a> , by creating separate forms for preferences and for changing your profile information.</p>
<p>This helps make the users#account form (and update logic) simpler, although it's still very complex. The preferences page is currently a bit sparse, but could be expanded as we add more things to the site, and could be improved by much better descriptions of how the language preferences are supposed to work! Again, these can be follow-on tasks.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3257'>https://github.com/openstreetmap/openstreetmap-website/pull/3257</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Split user preferences into a separate page</li>
  <li>Remove code complexity around resetting language preferences</li>
  <li>Move profile-related settings to their own form</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-961c5d7e0310073ca00d502eda2687808102441be660a654cab29645fbcea019">app/controllers/confirmations_controller.rb</a>
    (4)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-2ff63b142551396d9bd9b4246101b9473bc7cbc50f35ff36efdf01fe7dc7696c">app/controllers/preferences_controller.rb</a>
    (32)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-7a47d335107fc35c2e79cc9c2b0a195c863594dd2343bcd48a4c770ac4af673c">app/controllers/profiles_controller.rb</a>
    (43)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
    (30)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-9802ca3c9c4cf89904fd44bc114e35ebdf2c5dd3d5b645491e2b253e1afef29b">app/models/user.rb</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-6d2ef58207c92d1533287af551a075122ba98240a861819047a2ae77b7674f0b">app/views/layouts/_header.html.erb</a>
    (1)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-15b1d78abba5c7bc2d2b6c6d79f05073fc20a9814670c28ea97e8ec51f8fd9d5">app/views/preferences/edit.html.erb</a>
    (12)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-a495929ae8cf23fcea871e8aaa1bc52607a4e0f911f47d6bee5915e18d4a813e">app/views/preferences/show.html.erb</a>
    (28)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-6091542e4570d68ca546a4a893b0d0202a75b9aa6fabf4e8aa0b4122ae6a3544">app/views/profiles/edit.html.erb</a>
    (61)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-3f056c5b33f8be8ff39055a0bb2bcd67e09728200c0cd0543bd9f40d9b82761b">app/views/users/account.html.erb</a>
    (51)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-78ff736409d758722403cce31873ba803b3fb526d37398ca21caa557b54dfd95">app/views/users/show.html.erb</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
    (53)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
    (3)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-9d330c9b4c315df4e0b0a23cd48461483d1dd153a9976aa056dc7b9b1258a01a">test/controllers/preferences_controller_test.rb</a>
    (56)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-6ad6fcf04b256a25747cfe704f2e34405ccb340f00b049eb348ee02410d747c5">test/controllers/profiles_controller_test.rb</a>
    (67)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257/files#diff-2719d3c650da3c587f727ca3c105e6bc93a7113f85717bb15983543cf4f85ae5">test/controllers/users_controller_test.rb</a>
    (74)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3257.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3257.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3257.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3257.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKVCV22PJXE66BMPKTTXW6DTANCNFSM5AL23W7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLNGBTYACGSP3LJIGTTTXW6DTA5CNFSM5AL23W72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OCNYPWQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3257",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3257",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>