<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257#discussion_r674208364">app/views/preferences/show.html.erb</a>:</p>
<pre style='color:#555'>> +
+<dl class="row">
+ <dt class="col-sm-4"><%= t ".preferred_editor" %></dt>
+
+ <% if current_user.preferred_editor? %>
+ <dd class="col-sm-8"><%= t("editor.#{current_user.preferred_editor}.description") %></dd>
+ <% else %>
+ <dd class="col-sm-8"><%= t("editor.default", :name => t("editor.#{Settings.default_editor}.name")) %></dd>
+ <% end %>
+
+ <dt class="col-sm-4"><%= t ".preferred_languages" %></dt>
+
+ <dd class="col-sm-8">
+ <ul>
+ <% current_user.preferred_languages.each do |locale| %>
+ <li><%= locale %></li>
</pre>
<p>I thought I had mentioned this in my previous review but apparently I missed it...</p>
<p>I don't know about you but I'm not particularly keen on the bulleted list here... What do you think to just a simple list? (I did <code>list-style: none; padding-left: 0</code> to test it)</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257#discussion_r674209148">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -1644,6 +1644,42 @@ en:
reset: "Reset Password"
flash changed: "Your password has been changed."
flash token bad: "Did not find that token, check the URL maybe?"
+ preferences:
+ show:
+ title: My Preferences
</pre>
<p>This, and the other titles are in title case but I think we generally only capitalise the first word of page titles? Though I'm not sure I don't prefer it this way...</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3257#pullrequestreview-711989032">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO3NDT23TAUTFRJGZLTY4C6ZANCNFSM5AL23W7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLKVOI3JAOP5PZLA4TTTY4C6ZA5CNFSM5AL23W72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFJYBOKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3257#pullrequestreview-711989032",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3257#pullrequestreview-711989032",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>