<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r696122545">app/controllers/site_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -106,6 +106,11 @@ def about
     @locale = params[:about_locale] || I18n.locale
   end
 
+  def communities
+    @locale = params[:communities_locale] || I18n.locale
</pre>
<p>If it's just a about translation why are you allowing the language to be overridden? You should just use <code>I18n.locale</code> if that's what you're trying to do.</p>
<p>The only page where we allow overriding like this is the copyright page, for legal reasons to do with being able to switch between english and the localised form.</p>
<p>A more general ability to override the language is a much requested feature but it should be done system wide not on a per page basis like this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r696122545">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPCJT3H6YFTDIX5V23T6VNIRANCNFSM5CXUIRLQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/AAK2OLKCJ4CY2MRYFEQYMK3T6VNIRA5CNFSM5CXUIRL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFQE5J5I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r696122545",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r696122545",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>