<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> apologies for the delay getting back to this - I've refactored the data stuff in a way that I <em>think</em> is an improvement. At any rate I'm a bit less embarrassed by it now. I'm not sure if <code>lib</code> is the right place to put these, but it seems better than <code>models</code>.</p>
<p>I'm still not really sure how to add tests to it, considering how dependent it is on the npm lib / data files, but I'll take a look at the tests that exist already and see if I can find any similar patterns to be inspired by.</p>
<p>Anyway I'd love to get any / all feedback you have (and that applies to anyone else reading this too <g-emoji class="g-emoji" alias="wave" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f44b.png">👋</g-emoji> )</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-915528108">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOKSPOFLPMEF47GYHTUA6535ANCNFSM5CXUIRLQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAK2OLLVYP622EQHRQLQ7MLUA6535A5CNFSM5CXUIRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG2I5TLA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-915528108",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-915528108",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>