<p>This PR refactors the changeset download method to use a builder template, instead of using model methods to create the XML. This allows us to remove the final <code>to_xml</code> and <code>to_xml_node</code> from the models, and also allows us to remove the related ObjectMedata concern (by moving the relevant code to the tests, where it's still used for creating xml fixtures).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3324'>https://github.com/openstreetmap/openstreetmap-website/pull/3324</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Use a builder to render changeset downloads</li>
  <li>Move the xml format test for old nodes to the controller test</li>
  <li>Remove unused to_xml and to_xml_node methods from models</li>
  <li>Remove the ObjectMetadata concern, since it's only used in tests now</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-6726f8601cd22886963fb41888b55956cae4f8124aa12c701da77c3add44d94c">app/controllers/api/changesets_controller.rb</a>
    (42)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-e593acd6d0bd49f7bafdd1781286aa912231dfdeb168ba0a03a6c1aff9c4c95e">app/models/concerns/object_metadata.rb</a>
    (43)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-d521fcf96c3de2b8c810e0e8da2c12824cd1de1a7999f8b600284e8f358703c1">app/models/node.rb</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-4c50108aa94328d5d91f43621940bf6ddc6e71541957230e73bd67984a149f02">app/models/old_node.rb</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-5db6f2fd2ae37c6c561b35eb05d1b8cc8269f2be66904f04456350839ce76a4a">app/models/old_relation.rb</a>
    (26)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-f5c22ac10c6752867ac4b5758139cac9801401c0d514fa597cfbaa08e099b0c3">app/models/old_way.rb</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-bd34d574a6519bf199e087e2c1cb091c789c2a9e76b22ab8b454ddfc43e1fdd0">app/models/relation.rb</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-bedc4e8b2c0975fdcb8401541fbed87e09c8cc55e265cf7802fba772e6b5aaf7">app/models/way.rb</a>
    (1)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-aa90750416309a6aca2d2dd71a40d9c4ec0f616c9e51f7a06174245a0a9c8ca4">app/views/api/changesets/download.xml.builder</a>
    (19)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-e95198c7f7744be3ce9857db36d2374538ca7d64caaf0f6f85865d6752563ee9">test/controllers/api/changesets_controller_test.rb</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-7ee3168144cba950374d481967d27d39db360d6dfb366aa9033b42f32cb98256">test/controllers/api/old_nodes_controller_test.rb</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-4cb11fbe79667f6d824ec1077516decafcc8ed8553e484ee5e414fe8b5cbba55">test/models/old_node_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a">test/test_helper.rb</a>
    (52)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3324.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3324.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3324.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3324.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3324">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOG3NZFI3SM47FYD7TUCDBFDANCNFSM5EC2A2ZQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAK2OLL6BVXDXCNMFWV555TUCDBFDA5CNFSM5EC2A2Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4O3REG7A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3324",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3324",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>