<p dir="auto">This PR reduces the usage of margin-top for controlling layouts. Bootstrap <a href="https://getbootstrap.com/docs/4.0/content/reboot/" rel="nofollow">tries to avoid margin-top</a> since they collapse into preceding margin-bottoms, so it's easier to be consistent and just use margin-bottoms instead. Since they are applied to most elements (like tables, lists, paragraphs) by default, some refactoring of plain text-in-div to text-in-paragraph solved the spacing problems, otherwise I used the bootstrap margin utilities.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3362'>https://github.com/openstreetmap/openstreetmap-website/pull/3362</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/2b84452222db25cfcfdc2a788ebea79d2ea517f7">Remove custom margins on sidebar headings</a></li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/826a864e6c3e1f733b74d6d5aacf6b3253507a75">Remove the contact-activity class</a></li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/6bce75b134a1175359360c5e3ee17bb8edfeb6f0">Add button classes for users list action buttons</a></li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/ea0f128e9e5d5f42e41adc44e1fa6cd45f608bcb">Remove the paragraph margin overrides for the users list</a></li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/abe855150656ca2fdb7d786716b3c14bea164265">Remove custom css overrides for the users list</a></li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files">8 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(29)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-9dea4ffe487a631e3df942ebeec041974e762348f767704f27c52bc97e89052f">app/views/browse/_common_details.html.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-fba7159a4abd78f8b24f765a0c58ebe47a24be99e185c373175f20f612a5d781">app/views/browse/changeset.html.erb</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-a893bdff25132b2a60513f4fb74deb7507b568af429e60d05a48c63b7dd95230">app/views/dashboards/_contact.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-e390cd3017ea55a29b03a500b95a0203d99769e74ccc353cd2bd8c2bf058ec63">app/views/dashboards/show.html.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-2f2f2a0bc9c3675306c20ed740c32fad7b057eae15952a8dd2455d3eb661a49f">app/views/users/index.html.erb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-36fc67e1b6b8bcf4835a42cb762caa3caa45dce59deb15ba0339e4df1ec1d38c">test/controllers/dashboards_controller_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/files#diff-61df78335fb0a8542698c24b6fb46b1f5e144e6c207382c2713abb64f97b05f8">test/integration/user_changeset_comments_test.rb</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3362.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3362.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3362.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3362.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLOVH3ZIKJ3L3GXAMTULJQ6BANCNFSM5HXY7ZKQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAK2OLO76RCROK7N6HKLKO3ULJQ6BA5CNFSM5HXY7ZK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4PUSFTSQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3362",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3362",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>