<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3419#discussion_r783722174">app/models/user.rb</a>:</p>
<pre style='color:#555'>> +    # Used in test suite, not something that we would normally need to do.
+    event :deactivate do
+      transitions :from => :active, :to => :pending
+    end
</pre>
<p dir="auto">Well if it was only used for test cases then we should just remove those test cases as by definition we would be testing functionality that wasn't used in real life - that's better than polluting the source with comments.</p>
<p dir="auto">As I said in my review though currently there is a production use case, it's just that this PR currently removes the ability to use it. There's probably no need for it though, if I was able to move people from suspended/confirmed to active though.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3419#discussion_r783722174">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLOJ4GUQKTMC5OZZODUV2CZVANCNFSM5LZUSQPA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPXY4KE7NVST5LL2YLUV2CZVA5CNFSM5LZUSQPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGK7PSDA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3419/review/851376396</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3419#discussion_r783722174",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3419#discussion_r783722174",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>