<p></p>
<p dir="auto"><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> I would think most users are interested in <code>open</code> (unresolved) notes (which they likely want to solve), which would be displayed first by this PR, so IMHO there would be less confusion (as users would be shown firstly what there are most likely interested in).<br>
Also, visual cues (first all red, then all green) should help few users who are looking for their closed notes figure out new ordering.</p>
<p dir="auto">(One could verify that theory by correlating web-server logged user clicks on notes by their status, but that is quite likely overkill.)</p>
<p dir="auto">Although if you still think users might be confused by improved ordering, we can update the text shown, something like:</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-md"><span class="pl-md">-</span>Notes submitted or commented on by %{user}</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>Notes submitted or commented on by %{user} are ordered by first showing all open notes, followed by closed notes</span></pre></div>
<p dir="auto">That would help keep the patch simple and correct. Would you prefer that, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3386#issuecomment-1033156792">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKZDJ6FL3TED2NRXITU2GP5JANCNFSM5I54RJ4A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKTZ7GH3SWWFEVUPULU2GP5JA5CNFSM5I54RJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHWKLROA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3386/c1033156792</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3386#issuecomment-1033156792",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3386#issuecomment-1033156792",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>