<p dir="auto">This partially addresses <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1148261185" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3471" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/3471/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/3471">#3471</a> by adding <code>:inverse_of</code> to as many relationships that need it as we can easily do.</p>
<p dir="auto">There are some which either don't have an inverse relationship, or which are conditional so that the inverse is not really an exact inverse, or where (like doorkeeper) we don't actually control the class on the other end.</p>
<p dir="auto">The cop is now enabled, but with exceptions for files which still have issues to be resolved.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3472'>https://github.com/openstreetmap/openstreetmap-website/pull/3472</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/commits/03fdc6d67f1826b1a202eb50c284fa9202af24af" class="commit-link">03fdc6d</a> Add inverse_of to relationships that can't detect it automatically</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files">20 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5c">.rubocop.yml</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-29beaabe278fd17493296745cecb67919f0906b47b8246ab770f5517615d9ef7">.rubocop_todo.yml</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-d8b3d068c5bcf3464bff0f2273bab8d609b7f6b4afd6089020aff892dc4ce88f">app/models/diary_entry.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-fd43972003954839a7b36a37076c3a2202c6e4e7766fac5f04bc53a8f09a8f29">app/models/language.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-d521fcf96c3de2b8c810e0e8da2c12824cd1de1a7999f8b600284e8f358703c1">app/models/node.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-08ddccf408b18937e98b422e555eaf851c2a02c3ba815c5aeb8bc00efe65ecab">app/models/note.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-4c50108aa94328d5d91f43621940bf6ddc6e71541957230e73bd67984a149f02">app/models/old_node.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-0295f705dddcfcf5e8e96cf7dbb31b37b4f6f7c23dfa995d69b594ff1e718cba">app/models/old_node_tag.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-5db6f2fd2ae37c6c561b35eb05d1b8cc8269f2be66904f04456350839ce76a4a">app/models/old_relation.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-f510a509c00733955c511f9da416b20f0fb8deb43af469013be592a8e6150326">app/models/old_relation_member.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-68f5e5a44fc59dac556dd16880bba8083f2a01315c17f8bc0d7c442b3fe6d7ee">app/models/old_relation_tag.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-f5c22ac10c6752867ac4b5758139cac9801401c0d514fa597cfbaa08e099b0c3">app/models/old_way.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-a5462ede374b07191ef5724b5aefad7cb4cf3c4fad03cf516b16b59b15554523">app/models/old_way_node.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-dbfb1ec6b34c7e08ecc5402dda7ee5de8b977731153a87658c373c345d400329">app/models/old_way_tag.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-bd34d574a6519bf199e087e2c1cb091c789c2a9e76b22ab8b454ddfc43e1fdd0">app/models/relation.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-49ff8e13eb2bff9ffd834dad7421f568b40186cb58b28e7eac6b3e9168ec8759">app/models/trace.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-559c219461fd652d061995369a497c48b06dcbacae742f072503cc7cd5e86ced">app/models/tracepoint.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-354e220f3dd6df0eaf848fcc2f1e3624c2f7841b996f37dc180b36032f1be237">app/models/tracetag.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-9802ca3c9c4cf89904fd44bc114e35ebdf2c5dd3d5b645491e2b253e1afef29b">app/models/user.rb</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472/files#diff-bedc4e8b2c0975fdcb8401541fbed87e09c8cc55e265cf7802fba772e6b5aaf7">app/models/way.rb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3472.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3472.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3472.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3472.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3472">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPSLYOCGGEKINR7A5DU4UYH5ANCNFSM5PFJQFPA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJDH2BUCZ4ZZDQT2QTU4UYH5A5CNFSM5PFJQFPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4RDURZAA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3472</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3472",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3472",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>