<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<p dir="auto">Are we making this too complicated? This was on my todo list but I haven't fully thought it out yet. My initial reaction is that I thought we were going to end up with two states:</p>
<p dir="auto">a) We need to retain the account, and so we retain the email address<br>
b) We don't need to retain the account, and so the email address disappears at the point that we "properly destroy" the account.</p>
<p dir="auto">But here we are working where we need to keep the account but don't need to keep the email address. I guess this is to avoid notes, diary entries etc disappearing. I guess we should define exactly why we need to retain the email, which I think includes for relicensing issues, right? If so, do we need to include "has a trace?", since that's user generated data the we currently license too, that's not covered by changesets.</p>
<p dir="auto">My other thought is whether some of this could be implemented with a delay, to give time for abuse investigations, e.g. disable the account immediately and then properly destroy it after 14 days.</p>
<p dir="auto">But again, we should probably make a list of any reasons for retaining the email address, since that might guide the implementation.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3488#discussion_r819482621">app/views/account/deletions/show.html.erb</a>:</p>
<pre style='color:#555'>> @@ -21,6 +21,9 @@
 <ul>
   <li><%= t ".delete_profile" %></li>
   <li><%= t ".delete_display_name" %></li>
+  <% unless current_user.changesets.exists? -%>
</pre>
<p dir="auto">My initial thought is that we should abstract this slightly, e.g. <code>unless current_user.must_retain_email?</code> or similar. As per simonpoole's comment, there might be other situations where we need to retain the email.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3488#pullrequestreview-900101733">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIABIIZZENOCIIZ3ALU6HXAJANCNFSM5P3LLULA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKQOHUHW777UEPCD73U6HXAJA5CNFSM5P3LLULKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGWTHMZI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3488/review/900101733</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3488#pullrequestreview-900101733",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3488#pullrequestreview-900101733",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>