<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>
<p dir="auto">Just a couple of small layout/css tweaks, but otherwise looks good to me.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3492#discussion_r821708901">app/views/oauth_clients/index.html.erb</a>:</p>
<pre style='color:#555'>> @@ -34,10 +34,14 @@
<p><%= t(".no_apps_html", :oauth => link_to(t(".oauth"), "https://oauth.net")) %></p>
<% else %>
<p><%= t ".registered_apps" %></p>
-<% @client_applications.each do |client| %>
- <div class="client_application">
- <%= link_to client.name, :action => :show, :id => client.id %>
- </div>
-<% end %>
+<p>
</pre>
<p dir="auto">Should be a list (which has automatic bottom padding) rather than wrapping in a paragraph</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3492#discussion_r821711407">app/views/oauth_clients/index.html.erb</a>:</p>
<pre style='color:#555'>> <% end %>
-<h3><%= link_to t(".register_new"), :action => :new %></h3>
+<p>
</pre>
<p dir="auto">No need to wrap a button in a paragraph tag (and it's not really correct anyway, since the contents aren't a paragraph of text).</p>
<p dir="auto">The final button on the page doesn't need any bottom padding anyway.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3492#pullrequestreview-903080077">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMPP4MDQLFNCST2ZQDU65PIPANCNFSM5QGIBAQA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKZOEKET5EMQNVBJLTU65PIPA5CNFSM5QGIBAQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGXJ6RDI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3492/review/903080077</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3492#pullrequestreview-903080077",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3492#pullrequestreview-903080077",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>