<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p dir="auto">I think the main operational question here is, what is the performance impact of this likely to be - basically how many additional changesets may the database have to consider to try and find ones which fit in the view?</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3417#discussion_r822490804">app/controllers/changesets_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -78,18 +78,35 @@ def feed
   # utility functions below.
   #------------------------------------------------------------
 
+  ##
+  # The API has few situations, where parameter is supposed
+  # to have boolean value (true/false), but previously their
+  # values were ignored and script checked only null/not null
+  # state.
+  # If string value is true, return boolean true, otherwize false.
+  def check_boolean(value)
</pre>
<p dir="auto">If this is needed by multiple controllers then it should be moved up to <code>application_controller.rb</code> instead of duplicating it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3417#pullrequestreview-904141384">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNZJ3CECEKKG7Y6T6TU7B26TANCNFSM5LXXYWSA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO4BJMXONDJIEKFQL3U7B26TA5CNFSM5LXXYWSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGXSBUSA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3417/review/904141384</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3417#pullrequestreview-904141384",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3417#pullrequestreview-904141384",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>