<p></p>
<p dir="auto">I think it might be worthwhile comparing different options for a single changeset in <code>changeset.json.jbuilder</code>:</p>
<h4 dir="auto">Option 1: Put single changeset in changesets array:</h4>
<div class="highlight highlight-source-ruby"><pre><span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">partial!</span> <span class="pl-s">"api/root_attributes"</span>
<span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">changesets</span><span class="pl-kos">(</span><span class="pl-kos">[</span><span class="pl-c1">@changeset</span><span class="pl-kos">]</span><span class="pl-kos">)</span> <span class="pl-k">do</span> |<span class="pl-s1">changeset</span>|
<span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">partial!</span> <span class="pl-s1">changeset</span>
<span class="pl-k">end</span></pre></div>
<p dir="auto">(see example above)</p>
<h4 dir="auto">Option 2: changeset element with single chageset</h4>
<div class="highlight highlight-source-ruby"><pre><span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">partial!</span> <span class="pl-s">"api/root_attributes"</span>
<span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">changeset</span> <span class="pl-k">do</span>
<span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">partial!</span> <span class="pl-c1">@changeset</span>
<span class="pl-k">end</span></pre></div>
<div class="highlight highlight-source-json"><pre>{
<span class="pl-ent">"version"</span>: <span class="pl-s"><span class="pl-pds">"</span>0.6<span class="pl-pds">"</span></span>,
<span class="pl-ent">"generator"</span>: <span class="pl-s"><span class="pl-pds">"</span>OpenStreetMap server<span class="pl-pds">"</span></span>,
<span class="pl-ent">"copyright"</span>: <span class="pl-s"><span class="pl-pds">"</span>OpenStreetMap and contributors<span class="pl-pds">"</span></span>,
<span class="pl-ent">"attribution"</span>: <span class="pl-s"><span class="pl-pds">"</span>http://www.openstreetmap.org/copyright<span class="pl-pds">"</span></span>,
<span class="pl-ent">"license"</span>: <span class="pl-s"><span class="pl-pds">"</span>http://opendatacommons.org/licenses/odbl/1-0/<span class="pl-pds">"</span></span>,
<span class="pl-ent">"changeset"</span>: {
<span class="pl-ent">"id"</span>: <span class="pl-c1">1874552</span>,
<span class="pl-ent">"created_at"</span>: <span class="pl-s"><span class="pl-pds">"</span>2021-01-23T22:01:04Z<span class="pl-pds">"</span></span>,
<span class="pl-ent">"open"</span>: <span class="pl-c1">false</span>,
<span class="pl-ent">"comments_count"</span>: <span class="pl-c1">0</span>,
<span class="pl-ent">"changes_count"</span>: <span class="pl-c1">260</span>,
<span class="pl-ent">"closed_at"</span>: <span class="pl-s"><span class="pl-pds">"</span>2021-01-23T22:01:13Z<span class="pl-pds">"</span></span>,
<span class="pl-ent">"min_lat"</span>: <span class="pl-c1">-12.2373657</span>,
<span class="pl-ent">"min_lon"</span>: <span class="pl-c1">-45.9127416</span>,
<span class="pl-ent">"max_lat"</span>: <span class="pl-c1">13.8360116</span>,
<span class="pl-ent">"max_lon"</span>: <span class="pl-c1">-25.2032019</span>,
<span class="pl-ent">"uid"</span>: <span class="pl-c1">2</span>,
<span class="pl-ent">"user"</span>: <span class="pl-s"><span class="pl-pds">"</span>mmd3<span class="pl-pds">"</span></span>,
<span class="pl-ent">"tags"</span>: {
<span class="pl-ent">"created_by"</span>: <span class="pl-s"><span class="pl-pds">"</span>JOSM/1.5 (17473)<span class="pl-pds">"</span></span>
},
<span class="pl-ent">"comments"</span>: []
}
}</pre></div>
<h4 dir="auto">Option 3: Merge changeset attributes in higher level element:</h4>
<div class="highlight highlight-source-ruby"><pre><span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">partial!</span> <span class="pl-s">"api/root_attributes"</span>
<span class="pl-en">json</span><span class="pl-kos">.</span><span class="pl-en">partial!</span> <span class="pl-c1">@changeset</span></pre></div>
<div class="highlight highlight-source-json"><pre>{
<span class="pl-ent">"version"</span>: <span class="pl-s"><span class="pl-pds">"</span>0.6<span class="pl-pds">"</span></span>,
<span class="pl-ent">"generator"</span>: <span class="pl-s"><span class="pl-pds">"</span>OpenStreetMap server<span class="pl-pds">"</span></span>,
<span class="pl-ent">"copyright"</span>: <span class="pl-s"><span class="pl-pds">"</span>OpenStreetMap and contributors<span class="pl-pds">"</span></span>,
<span class="pl-ent">"attribution"</span>: <span class="pl-s"><span class="pl-pds">"</span>http://www.openstreetmap.org/copyright<span class="pl-pds">"</span></span>,
<span class="pl-ent">"license"</span>: <span class="pl-s"><span class="pl-pds">"</span>http://opendatacommons.org/licenses/odbl/1-0/<span class="pl-pds">"</span></span>,
<span class="pl-ent">"id"</span>: <span class="pl-c1">1874553</span>,
<span class="pl-ent">"created_at"</span>: <span class="pl-s"><span class="pl-pds">"</span>2021-01-23T22:01:41Z<span class="pl-pds">"</span></span>,
<span class="pl-ent">"open"</span>: <span class="pl-c1">false</span>,
<span class="pl-ent">"comments_count"</span>: <span class="pl-c1">2</span>,
<span class="pl-ent">"changes_count"</span>: <span class="pl-c1">10000</span>,
<span class="pl-ent">"closed_at"</span>: <span class="pl-s"><span class="pl-pds">"</span>2021-01-23T23:05:28Z<span class="pl-pds">"</span></span>,
<span class="pl-ent">"min_lat"</span>: <span class="pl-c1">-13.6479226</span>,
<span class="pl-ent">"min_lon"</span>: <span class="pl-c1">-62.78181</span>,
<span class="pl-ent">"max_lat"</span>: <span class="pl-c1">22.8223133</span>,
<span class="pl-ent">"max_lon"</span>: <span class="pl-c1">-24.9335172</span>,
<span class="pl-ent">"uid"</span>: <span class="pl-c1">2</span>,
<span class="pl-ent">"user"</span>: <span class="pl-s"><span class="pl-pds">"</span>mmd3<span class="pl-pds">"</span></span>,
<span class="pl-ent">"tags"</span>: {
<span class="pl-ent">"created_by"</span>: <span class="pl-s"><span class="pl-pds">"</span>JOSM/1.5 (17473)<span class="pl-pds">"</span></span>
}
}</pre></div>
<p dir="auto">Option 1 is the one currently implemented. I'm not sure which of those options would make most sense here.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3495#issuecomment-1065866706">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIMZYOYVKXXYQG5ILLU7R6DZANCNFSM5QKQVWOA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOG5ERJZJX4A7N4R4LU7R6DZA5CNFSM5QKQVWOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOH6D5LUQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3495/c1065866706</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3495#issuecomment-1065866706",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3495#issuecomment-1065866706",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>