<p></p>
<p><b>@harry-wood</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3542#discussion_r865163881">test/controllers/reports_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -63,10 +63,12 @@ def test_new_report_with_incomplete_details
       category = "other"
       post reports_path(:report => {
                           :category => category,
-                          :issue => { :reportable_id => 1, :reportable_type => "User" }
+                          :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
</pre>
<p dir="auto">For some reason swapping to <code>render</code> instead of redirect causes our test user to get created (or <em>more often</em> get created) with some id other than 1<br>
but anyway it should probably have always been <code>target_user.id</code> to make it less brittle.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3542#pullrequestreview-962331720">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIDH2FFRS7VXNHAVKLVILBOLANCNFSM5VBZLEXA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNNOQ3FQF5XB6LXKALVILBOLA5CNFSM5VBZLEXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHFOAISA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3542/review/962331720</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3542#pullrequestreview-962331720",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3542#pullrequestreview-962331720",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>