<p></p>
<blockquote>
<p dir="auto">So for example, <code class="notranslate">.layers-ui.base-layers li</code> contains <code class="notranslate">margin-bottom: 8px</code> - this is an example of a style rule that should be removed, and replaced with either a) nothing, since bootstrap applies appropriate margin-bottoms to most components anyway</p>
</blockquote>
<p dir="auto">But that's not going to happen in our case because:</p>
<ul dir="auto">
<li>layer selection buttons are not Bootstrap components</li>
<li>we want horizontal gap when two columns are visible - actually there is a default horizontal gap but it's too wide</li>
</ul>
<blockquote>
<p dir="auto">or b) a bootstrap utility, e.g. mb-3.</p>
</blockquote>
<p dir="auto">In <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1318586214" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3629" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3629/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/3629">#3629</a> I added <code class="notranslate">g-2</code> class to rows for 8px gap:<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3629/files#diff-87e33ea7d5e625dd851a78a3192719681de20caea8edd278a10f5342585c98e7R37">https://github.com/openstreetmap/openstreetmap-website/pull/3629/files#diff-87e33ea7d5e625dd851a78a3192719681de20caea8edd278a10f5342585c98e7R37</a></p>
<blockquote>
<p dir="auto">This way, margins are kept consistent all around the site,</p>
</blockquote>
<p dir="auto">Not in this case because I added a class just in this particular place.</p>
<blockquote>
<p dir="auto">and are easy to change by customising bootstrap centrally.</p>
</blockquote>
<p dir="auto">Not in this case unless you are going to redefine <code class="notranslate">g-2</code> globally.</p>
<blockquote>
<p dir="auto">So the same applies to grids, grid spacing, grid margins etc - no singular grid should have its own widths set,</p>
</blockquote>
<p dir="auto">But this grid has its own spacing etc.</p>
<blockquote>
<p dir="auto">since that means they are inconsistent with any other grid used in the site.</p>
</blockquote>
<p dir="auto">What this grid is supposed to be consistent with if there's no similar grid in the site?</p>
<p dir="auto">Was adding <code class="notranslate">g-2</code> wrong in this case? If it was should I have used the default values instead (larger horizontal gaps and no vertical gaps)? But they look ugly. If it wasn't, why? There's no consistency / centrality in this case and it's still specifying the gap but in a different place in different units.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1196859932">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLKFOQNKG4M3YDZSVLVWFD57ANCNFSM54SY7APA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMBHTGHPD6Y4VB2OXDVWFD57A5CNFSM54SY7APKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI5LKEHA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3620/c1196859932</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1196859932",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1196859932",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>