<p dir="auto">The margins mentioned in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1319980982" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3631" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3631/hovercard?comment_id=1203797930&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/3631#issuecomment-1203797930">#3631 (comment)</a> are likely no longer necessary. They were leftovers from floated buttons put inside headers, probably to align the buttons with the text baseline. And they only affect the button position in the left sidebar.</p>
<table role="table">
<thead>
<tr>
<th>With margin-top</th>
<th>Without margin-top</th>
</tr>
</thead>
<tbody>
<tr>
<td><a target="_blank" rel="noopener noreferrer nofollow" href="https://user-images.githubusercontent.com/4158490/188168631-ba9a6ff0-e236-4395-b1cf-961cd6c1cc11.png"><img src="https://user-images.githubusercontent.com/4158490/188168631-ba9a6ff0-e236-4395-b1cf-961cd6c1cc11.png" alt="b0" style="max-width: 100%;"></a></td>
<td><a target="_blank" rel="noopener noreferrer nofollow" href="https://user-images.githubusercontent.com/4158490/188168690-983a3aaa-c64b-44cc-ae6f-2a86f4e816c9.png"><img src="https://user-images.githubusercontent.com/4158490/188168690-983a3aaa-c64b-44cc-ae6f-2a86f4e816c9.png" alt="b1" style="max-width: 100%;"></a></td>
</tr>
</tbody>
</table>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3678'>https://github.com/openstreetmap/openstreetmap-website/pull/3678</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678/commits/fb75f447d72ca3c913a195f97abeba64c9142172" class="commit-link">fb75f44</a> Remove top margins from close buttons</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678/files">4 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678/files#diff-999fd69dc428de17d14446f737f8c03cd280be7b66a1ac07fb765b900a19c2c4">app/assets/javascripts/index/browse.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678/files#diff-c4925852e0efd740fa9486b55efb267e4d1f1984fcdcd3125c5d1784b7a0f7a1">app/assets/javascripts/leaflet.sidebar-pane.js</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678/files#diff-a822b3bdb367bb476aeea5e822498b298c7f314c747785581ea64963a9fd3363">app/views/application/_sidebar_header.html.erb</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3678.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3678.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3678.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3678.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3678">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI2NK5G7VECBOAGLZ3V4IEJTANCNFSM6AAAAAAQDKIB7U">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIV4JATTPUGP7UIKRLV4IEJTA5CNFSM6AAAAAAQDKIB7WWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFCE7XE4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3678</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3678",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3678",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>