<p></p>
<blockquote>
<p dir="auto">i think maybe it's because the descenders on the text are being included in the calculation, but the eye doesn't really see them when considering whether the image and text appear to be centred :-(</p>
</blockquote>
<p dir="auto">Yeah, I had left adjusting these icons out of my previous refactoring on that page since I hadn't come up with a good solution. Maybe a proper designer would know the answer, but I don't know what the best solution would be - maybe adjusting the size of the icons to match the <a href="https://en.wikipedia.org/wiki/Baseline_(typography)" rel="nofollow">baseline to cap height</a> or something like that. But then we're deep in the weeds of font-specific solutions, and then checking that the icon positioning is still appropriate for e.g. chinese characters, and I think that's too much to consider, given our limited resources.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3701#issuecomment-1252070525">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNNPJ33ZLQFTX3RHQTV7F6FVANCNFSM6AAAAAAQP4XYSQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJ6XL62NVJIPF3CJVLV7F6FVA5CNFSM6AAAAAAQP4XYSSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSKUEKH2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3701/c1252070525</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3701#issuecomment-1252070525",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3701#issuecomment-1252070525",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>