<p></p>
<blockquote>
<p dir="auto">I also found The parameter #{controller_name} is required a bit too extreme. Yes, it's super generic, but might be too fragile going forward (think: translations, maybe)</p>
</blockquote>
<p dir="auto">How do you think the translation string would look like? I think it would be about as extreme. And again, I can do abstract method returning the message.</p>
<blockquote>
<p dir="auto">I would completely remove the ElementsApiController</p>
</blockquote>
<p dir="auto">Why not remove ApiController too?</p>
<blockquote>
<p dir="auto">and add around 10 lines to each of three controllers.</p>
</blockquote>
<p dir="auto">I'd remove around 80 lines from each.</p>
<p dir="auto">I already managed to sneak in an abstract class removing triple copy-paste, although it was in javascript.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-1258047784">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOHWKSDHOMQ3CDIACTWAGQR5ANCNFSM6AAAAAAQUBL4IE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIMPU2RCH6GVWV5GY3WAGQR5A5CNFSM6AAAAAAQUBL4IGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSK7RESQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3715/c1258047784</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-1258047784",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-1258047784",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>