<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">I really don't understand some of the breakdown of changes into commits here - the first and last commits are fairly obvious but <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/591a7464127f5a0e884e34cc4480d257ebc44cb9/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/591a7464127f5a0e884e34cc4480d257ebc44cb9"><tt>591a746</tt></a> and <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/4f9d7fbe7f36b449c9ed544969a8313763240f7d/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/4f9d7fbe7f36b449c9ed544969a8313763240f7d"><tt>4f9d7fb</tt></a> have descriptions that don't really explain what the commit is doing and for the second one especially I don't really understand what either of the two small changes have to do with each other or with the title of the commit.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3718#discussion_r981484149">app/assets/javascripts/index/note.js</a>:</p>
<pre style='color:#555'>> @@ -20,40 +19,41 @@ OSM.Note = function (map) {
       iconAnchor: [12, 40]
     })
   };
+  noteIcons.hidden = noteIcons.closed; // TODO replace with actual "hidden" icon when it's added
</pre>
<p dir="auto">Why do we want an icon for hidden notes? They are supposed to be hidden...</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3718#discussion_r981487824">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> @@ -37,7 +37,8 @@ OSM = {
   SEARCHING:               <%= image_path("searching.gif").to_json %>,
 
   apiUrl: function (object) {
-    var url = "/api/" + OSM.API_VERSION + "/" + object.type + "/" + object.id;
+    var apiType = object.type === "note" ? "notes" : object.type;
</pre>
<p dir="auto">This is kind of ugly... I'm half inclined to say why not just use <code class="notranslate">notes</code> as the object type, then you wouldn't need to jump through hoops here to fix things up.</p>
<p dir="auto">Then again that means internally we are inconsistent about whether the object type is singular or plural, which also offends me ;-)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3718#pullrequestreview-1122346507">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPR25SSAQWEPY4SJD3WAMRMZANCNFSM6AAAAAAQUZ2EEI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLEESZ5LJ44AX4MDDDWAMRMZA5CNFSM6AAAAAAQUZ2EEKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSC4WTAW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3718/review/1122346507</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3718#pullrequestreview-1122346507",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3718#pullrequestreview-1122346507",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>