<p></p>
<p dir="auto">The breakdown by commit is not ideal because I didn't know what I'd have to change when I started writing. Everything here can be broken down into six independent parts:</p>
<ol dir="auto">
<li>making notes to be "current objects" of the map</li>
<li>using note current objects to update edit links</li>
<li>calling the remote control commands - these 3 parts are required to see any working changes</li>
<li>test - previous 3 parts are required unless you want to tolerate failing tests</li>
<li>using the "closed" note marker as the "hidden" one too - not required, as long as you want javascript errors to keep happening when the "Hide" button is pressed</li>
<li>removing note id data attributes from the buttons in the view template - this is not required, but they are not used anywhere because the path is also written for each button and it contains the id. I removed the ids while I was thinking how to pass one to the edit link. The code before my changes didn't require these ids at all, they were ignored. Then there's also a client-side router for pages that contain a map. It is set up here: <a href="https://github.com/openstreetmap/openstreetmap-website/blob/f398c1e5eb35fa9e355544fb2860bc2ca9cfbe67/app/assets/javascripts/index.js#L360">https://github.com/openstreetmap/openstreetmap-website/blob/f398c1e5eb35fa9e355544fb2860bc2ca9cfbe67/app/assets/javascripts/index.js#L360</a> It also passes the id to the note route handler - and it was also ignored. I decided to use it.</li>
</ol>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3718#issuecomment-1261480992">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI23DF2YWVNDPDNID3WASZTLANCNFSM6AAAAAAQUZ2EEI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIJ646MTT6OICMUWPTWASZTLA5CNFSM6AAAAAAQUZ2EEKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSLGCWCA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3718/c1261480992</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3718#issuecomment-1261480992",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3718#issuecomment-1261480992",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>