<p dir="auto">Since the pull request <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1368321834" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3682" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3682/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/3682">#3682</a> is not going anywhere I'll start taking it apart. Here are the changes in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/10319cac0d54ddb9e8f1f467cf16928646474730/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/10319cac0d54ddb9e8f1f467cf16928646474730"><tt>10319ca</tt></a>.</p>
<p dir="auto">On any history page that displays a list of changesets the "Load more" button loads more changesets. This button creates another list element for those changesets. You get as many lists as the number of times you pressed the button plus the original list. There's a line between list items but no line between lists. To the user it looks like some dividing lines are missing. Here you can see that there's no line between the second and the third changesets:<br>
<a target="_blank" rel="noopener noreferrer nofollow" href="https://user-images.githubusercontent.com/4158490/198023636-64481df5-e98f-46f7-a166-9504782b6be1.png"><img src="https://user-images.githubusercontent.com/4158490/198023636-64481df5-e98f-46f7-a166-9504782b6be1.png" alt="history-ols" style="max-width: 100%;"></a></p>
<p dir="auto">This PR makes "Load more" to merge the changesets it loads into the original html list so there's only one list.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3769'>https://github.com/openstreetmap/openstreetmap-website/pull/3769</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3769/commits/34a8d0820969019d796f4bd103077fb2c785badc" class="commit-link">34a8d08</a> Merge changeset <ol>s on Load more</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3769/files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3769/files#diff-25cab16df4a58e0c8e53d0a0e70d9bbf28ef3beb9e6bf1208234fdeed7515392">app/assets/javascripts/index/history.js</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3769/files#diff-ca76ddfd495be1ab96863518b57d1e0b49d06c99429adb2bbd6001692d12073b">test/system/history_test.rb</a>
(43)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3769.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3769.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3769.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3769.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3769">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN7KZZOZY7PMSXV2HTWFEPWDANCNFSM6AAAAAARO6F2MI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMS5FH2VMS7X3UINK3WFEPWDA5CNFSM6AAAAAARO6F2MKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFJX42C4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3769</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3769",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3769",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>