<p dir="auto">This is <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/cc9bcce5f0531243c34ffab8d43bc2885ff106ef/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/cc9bcce5f0531243c34ffab8d43bc2885ff106ef"><tt>cc9bcce</tt></a> + <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/b9f05806dbda4c33fcad5c1d68cb59623c432989/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/b9f05806dbda4c33fcad5c1d68cb59623c432989"><tt>b9f0580</tt></a></p>
<p dir="auto">When I was changing close buttons to Bootstrap's <code class="notranslate">class="btn-close"</code>, I kept the one in the left sidebar as a link. It was a "geolink" and I didn't want to remove it because "geolinks" are updated when map view changes and I didn't know exactly how it was happening. Later in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1368321834" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3682" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3682/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/3682">#3682</a> I finally replaced it with a button. I think I did it so I could cache the entire sidebar without worrying about map view updates.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3770'>https://github.com/openstreetmap/openstreetmap-website/pull/3770</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3770/commits/dbcf25697613cdb2641f991759c75d890254db2a" class="commit-link">dbcf256</a>  Use close button instead of geolink in sidebar content</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3770/files">2 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3770/files#diff-cdc070ced1c4000efd1e28357fd26b2fd617d7fccfeae0324222231db75dd6ee">app/assets/javascripts/index.js</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3770/files#diff-a822b3bdb367bb476aeea5e822498b298c7f314c747785581ea64963a9fd3363">app/views/application/_sidebar_header.html.erb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3770.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3770.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3770.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3770.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3770">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPKITODJJOVF2PYAKTWFEXHHANCNFSM6AAAAAARPABE2E">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI3WUI4ES5IIMQ7DSDWFEXHHA5CNFSM6AAAAAARPABE2GWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFJYIFY4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3770</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3770",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3770",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>