<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3717#discussion_r1006696026">app/models/client_application.rb</a>:</p>
<pre style='color:#555'>> @@ -39,6 +39,7 @@ class ClientApplication < ApplicationRecord
 
   validates :key, :presence => true, :uniqueness => true
   validates :name, :url, :secret, :presence => true
+  # TODO: Consider using UrlValidator from validate_url gem.
</pre>
<p dir="auto">Turns out I've considered this before! But I'd forgotten about that. Unfortunately it won't work. <code class="notranslate">validate_url</code> requires a list of permitted schemes, but for oauth callbacks any scheme needs to be allowed. See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="591865449" data-permission-text="Title is private" data-url="https://github.com/perfectline/validates_url/issues/99" data-hovercard-type="issue" data-hovercard-url="/perfectline/validates_url/issues/99/hovercard" href="https://github.com/perfectline/validates_url/issues/99">perfectline/validates_url#99</a></p>
<p dir="auto">I think this comment can be removed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-1158019701">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOTE46SDU5POMGKRG3WFJKXTANCNFSM6AAAAAAQUYXU54">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKXEAYQNM23NLHDSSLWFJKXTA5CNFSM6AAAAAAQUYXU56WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSFAX5HK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3717/review/1158019701</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-1158019701",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-1158019701",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>