<p></p>
<blockquote>
<p dir="auto">Is that an issue for validation? They should all be valid URLs</p>
</blockquote>
<p dir="auto">The issue is more about maintaining the list of schemes (more likely to need revisions than if it was just http(s)), and what to do with ones we don't want to display (mailto, xmpp), what to do with ones we haven't yet allowed, whether to strip them out, drop the record, emit a warning during parsing etc. If it was just http/https/nil that was expected, then the out-of-course handling would need less careful thought.</p>
<blockquote>
<p dir="auto">I think this is an OCI bug. One of the <code class="notranslate">#</code> should be percent-encoded, and I've opened <a href="https://github.com/osmlab/osm-community-index/issues/592" data-hovercard-type="issue" data-hovercard-url="/osmlab/osm-community-index/issues/592/hovercard">osmlab/osm-community-index#592</a> about it.</p>
</blockquote>
<p dir="auto">Thanks. It's worth noting that our two approaches to URL validation (<code class="notranslate">validate_url</code> gem, <code class="notranslate">URI::DEFAULT_PARSER.make_regexp</code>) behave differently - one accepts the second <code class="notranslate">#</code>, one doesn't! So I don't want to imply too much that it's a bug in OCI, rather than just something we need to deal with ourselves.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-1293186591">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPS3XYDB7RC4EV3YCTWFI5S7ANCNFSM5CXUIRLQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLWI2OOBYVV3P35PGLWFI5S7A5CNFSM5CXUIRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJUKHMHY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3301/c1293186591</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-1293186591",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-1293186591",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>