<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3774#discussion_r1008910450">app/assets/javascripts/router.js</a>:</p>
<pre style='color:#555'>> @@ -179,8 +187,20 @@ OSM.Router = function (map, rts) {
};
router.load = function () {
- var loadState = currentRoute.run("load", currentPath);
+ var loadState = loadOrReload();
</pre>
<p dir="auto">What's the reason for putting this logic in a nested function if this is the only user?</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3774#discussion_r1008910591">app/assets/javascripts/router.js</a>:</p>
<pre style='color:#555'>> router.stateChange(loadState || {});
+
+ function loadOrReload() {
+ if (currentRoute.has("reload") && window.performance) {
+ var wasReloaded = window.performance.getEntriesByType("navigation").some(function (entry) {
+ return entry.type === "reload";
+ });
</pre>
<p dir="auto">I'm not familiar with <code class="notranslate">window.performance</code> but from a quick bit of reading on MDN it seems this if testing if there are any navigation events of type <code class="notranslate">reload</code> in the history but what's the scope of that? The comment you added says we're interest in whether this request was a reload?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3774#pullrequestreview-1161176853">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO4FVORIJ7JWLCQ6DLWF2YU3ANCNFSM6AAAAAARRBTWJI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM4MLXVBAX7OTRHYMDWF2YU3A5CNFSM6AAAAAARRBTWJKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSFGYTRK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3774/review/1161176853</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3774#pullrequestreview-1161176853",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3774#pullrequestreview-1161176853",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>