<p dir="auto">See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1319980982" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3631" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3631/hovercard?comment_id=1203797930&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/3631#issuecomment-1203797930">#3631 (comment)</a>. Now that all close buttons are actually button html elements, I can finish adding aria labels.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3778'>https://github.com/openstreetmap/openstreetmap-website/pull/3778</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/commits/6c415ef1422f9f5603cd2532225a4fb2b6260672" class="commit-link">6c415ef</a> Add aria-label to close buttons</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/files">5 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/files#diff-999fd69dc428de17d14446f737f8c03cd280be7b66a1ac07fb765b900a19c2c4">app/assets/javascripts/index/browse.js</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/files#diff-a822b3bdb367bb476aeea5e822498b298c7f314c747785581ea64963a9fd3363">app/views/application/_sidebar_header.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/files#diff-24e67bdbd0998dcc1abb24b30381fe87f4f79f1ba28d08a79057202aa5ebb4ff">app/views/layouts/_banner.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778/files#diff-60b815932a6942ef4da576f75ee4e9b670e2aeb07950b7f8494bdbedb319c8c2">app/views/layouts/_search.html.erb</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3778.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3778.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3778.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3778.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3778">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNE2X3QLDCHJQONRZLWGAXPBANCNFSM6AAAAAARTO3MZ4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIXYNN5CDQU3PETN43WGAXPBA5CNFSM6AAAAAARTO3MZ6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFKQ4RHQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3778</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3778",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3778",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>