<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3774#discussion_r1009408679">app/assets/javascripts/router.js</a>:</p>
<pre style='color:#555'>> @@ -179,8 +187,20 @@ OSM.Router = function (map, rts) {
};
router.load = function () {
- var loadState = currentRoute.run("load", currentPath);
+ var loadState = loadOrReload();
</pre>
<p dir="auto">I'm asking why put the logic in a function rather than just having it inline.</p>
<p dir="auto">Are you saying that function is only called once rather than each time the load function is invoked?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3774#discussion_r1009408679">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPAT7PBBOTVW4HI3ADWF7BJJANCNFSM6AAAAAARRBTWJI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPQEGX5H6NJUMGCRNDWF7BJJA5CNFSM6AAAAAARRBTWJKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSFICQD6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3774/review/1161863231</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3774#discussion_r1009408679",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3774#discussion_r1009408679",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>