<p></p>
<blockquote>
<blockquote>
<p dir="auto">It seems that "fixing" this involves an awful lot of complicated and fragile javascript</p>
</blockquote>
</blockquote>
<p dir="auto">~350 lines added, ~50 lines removed, 4 files and this is including tests.</p>
<blockquote>
<p dir="auto">If the basic behaviour was that pagination worked properly without javascript, then we could use a small amount of javascript to enhance this (e.g. viewing more items without a full page reload).<br>
But what we have is javascript-only psuedo-pagination,</p>
</blockquote>
<p dir="auto">I don't alter the current pagination to make a smaller change first. This way I can avoid making server-side changes.</p>
<p dir="auto">Currently the pagination works with these requests<br>
<a href="https://www.openstreetmap.org/user/(username)/history?list=1&max_id=(id)" rel="nofollow">https://www.openstreetmap.org/user/(username)/history?list=1&max_id=(id)</a><br>
returning a limited amount of changesets starting from the specified id. It's possible to add full pages with urls like this, for example<br>
<a href="https://www.openstreetmap.org/user/(username)/history?max_id=(id)" rel="nofollow">https://www.openstreetmap.org/user/(username)/history?max_id=(id)</a><br>
then have "Load more" to link to them. Is it going to be "pagination working properly without javascript"?</p>
<blockquote>
<p dir="auto">and then we're looking at adding even more javascript to make it behave more like regular page loads. This seems the wrong strategy.</p>
</blockquote>
<p dir="auto">That's what router.js already does.</p>
<blockquote>
<p dir="auto">I also think adding more javascript that's changing urls,</p>
</blockquote>
<p dir="auto">Which I don't do yet.</p>
<blockquote>
<p dir="auto">hooking into the browser page reloads etc,</p>
</blockquote>
<p dir="auto">Which I also don't do. <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1427230414" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3774" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3774/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/3774">#3774</a> only detects if a reload happened. And it's not required, you just wouldn't know about a reload and wouldn't know to flush the cache for this reason.</p>
<blockquote>
<p dir="auto">is either duplicating or will eventually conflict with <a href="https://turbo.hotwired.dev/" rel="nofollow">turbo</a>, which broadly covers this kind of functionality. I'm not saying we should use turbo to as part of the fix (although I'd happily review that) but what I want to avoid is making our lives harder in future.</p>
</blockquote>
<p dir="auto">Do you want a bigger rewrite?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/647#issuecomment-1298624196">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN22TIQID2HJOR6J4LWGEVGHANCNFSM4AKLXOMQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJYG3L4LOFUY3MLAL3WGEVGHA5CNFSM4AKLXOM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJVTW5RA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/647/1298624196</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/647#issuecomment-1298624196",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/647#issuecomment-1298624196",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>