<p dir="auto">Where actions were reordered, the rails standard actions were also moved to the top of each controller.</p>
<p dir="auto">My personal preference is for index/new/create/edit/update/destroy (i.e. pair off new/create and edit/update) but I guess it's better to follow the default order, which is based on the rails scaffolding order too.</p>
<p dir="auto">I would be delighted at some point if we get to the point of having <em>only</em> these actions, but that's work for another day. <g-emoji class="g-emoji" alias="smiley" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f603.png">😃</g-emoji></p>
<p dir="auto">I've also fixed a comment (by deleting most of it) that I noticed while reordering actions - it referred to the old approach of having multi-purpose actions which was refactored a while ago.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3781'>https://github.com/openstreetmap/openstreetmap-website/pull/3781</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/commits/22946d703a1186d0ec7fb18a663f73855bb49546" class="commit-link">22946d7</a>  Enable the ActionOrder cop for remaining controllers</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/commits/6bbd8490feee13e2a2f5e2c0c0673a18f244e2dc" class="commit-link">6bbd849</a>  Remove outdated comments</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files">14 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-29beaabe278fd17493296745cecb67919f0906b47b8246ab770f5517615d9ef7">.rubocop_todo.yml</a>
    (21)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-6726f8601cd22886963fb41888b55956cae4f8124aa12c701da77c3add44d94c">app/controllers/api/changesets_controller.rb</a>
    (28)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-73fe5812764d31443ba0d43f028e68aa17963e92fe69d79f72957f5ac1a176b9">app/controllers/api/nodes_controller.rb</a>
    (48)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-6e9fe051c0ef757618e376ffe731dfca8d4960ef0838b7d6a05609b46ba0fad1">app/controllers/api/notes_controller.rb</a>
    (100)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-49b8b506dea5e046c47e71134ed6d1c4ca794559572895c26b1df469ceda868d">app/controllers/api/relations_controller.rb</a>
    (44)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-e84777f55861eeb73fed3029e0429118ff087b7dd2314e398acadc4157dbaa05">app/controllers/api/traces_controller.rb</a>
    (58)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-52cb10dc1aabfdb745ff2c590fb82ce44f6f1078750119a2b1305505475f7909">app/controllers/api/users_controller.rb</a>
    (32)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-eb50706672183bce46654d5a373c3df75906a65a3ae5055a16ba0d8d2005ca37">app/controllers/api/ways_controller.rb</a>
    (44)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-4b73866ef57c70fca07c0f330d7a57aae939b11e4aae0514f303df3aa3762f89">app/controllers/diary_entries_controller.rb</a>
    (144)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-9b58332ea76756301b1aafeacfb0659d1244ba014947602b0e0bf2d0f2921d26">app/controllers/messages_controller.rb</a>
    (73)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-e712a8df307b530ca702e97779daa3400119cc79eb20d81afa5efb1f9909b0fb">app/controllers/oauth_clients_controller.rb</a>
    (28)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-e3fc479be273e6b821713f2bb570401bad4850e4ba0beb728281426b191e34e3">app/controllers/redactions_controller.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-2602c06a2618f83c1470c924563b55c738e3c94ffb6480e637ca0f4ce130eaba">app/controllers/traces_controller.rb</a>
    (80)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
    (206)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3781.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3781.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3781.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3781.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3781">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLGXNKYWCFWKYP7FKDWGJGGBANCNFSM6AAAAAARU7INZE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKTMNOD4JP7VLRP25TWGJGGBA5CNFSM6AAAAAARU7INZGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFK2M2ZM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3781</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3781",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3781",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>